Co #14338: pallet-glutton: over-unity consumption

[ggwpez]

Companion for paritytech/substrate#14338

Change:

• Perbill to FixedU64
• Rename *_percent to *_ratio
• Fix typos

[NachoPal]

bot fmt

[command-bot]

@NachoPal https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2977408 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-41b932fa-987d-45bb-9e01-bbb34c3c7263 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2977408 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2977408/artifacts/download.

[NachoPal]

If the actual spent PoV depends on benchmarked weights. Does it mean we shouldn't regenerate the Weights for this calculations to remain correct?

[ggwpez]

If the actual spent PoV depends on benchmarked weights. Does it mean we shouldn't regenerate the Weights for paritytech/substrate#14338 (comment) calculations to remain correct?

Yea I will call the benchbot, thanks for noticing.
There should be no change, but lets see.

PS: The upstream CI is green now, so this MR should be good.

[NachoPal]

Yea I will call the benchbot, thanks for noticing.

The runtime is using local weights though. If you want to update them you should run the benchbot also here

[ggwpez]

The runtime is using local weights though. If you want to update them you should run the benchbot also here

I hope weights are updated prior to releases anyway?
But can still do once upstream merged. Only downside is that this will block the Cumulus CI check for 2-3 hours for everyone.

[ggwpez]

Maybe I can also diener it and call the bot directly here, will try.

[NachoPal]

I hope weights are updated prior to releases anyway?

Yes, they will be, but we are not waiting for next release to deploy Gluttons, we get the runtime from master.

I would just leave the weights as they are.

[paritytech-processbot]

Merge cancelled due to error. Error: Command 'Command { std: cd "/storage/repositories/cumulus" && "git" "push" "paritytech" "oty-glutton-overunity", kill_on_drop: false }' failed with status Some(1); output: To https://github.com/paritytech/cumulus.git
! [rejected] oty-glutton-overunity -> oty-glutton-overunity (fetch first)
error: failed to push some refs to 'https://github.com/paritytech/cumulus.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

[ggwpez]

bot merge

The bot did not try to update. So doing it manually now.

[paritytech-processbot]

Waiting for commit status.