This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Store PendingUpwardMessages in pallet-paged-list
#2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
commented
Jul 25, 2023
| UpwardMessages::<T>::put(&up[..num]); | ||
| *up = up.split_off(num); | ||
| }); | ||
| // TODO: #274 Return back messages that do not longer fit into the queue. |
There was a problem hiding this comment.
Dont think #274 applies here anymore.
ggwpez
changed the title
pallet-paged-listpallet-paged-list to store PendingUpwardMessages
ggwpez
changed the title
pallet-paged-list to store PendingUpwardMessagesPendingUpwardMessages in pallet-paged-list
kianenigma
reviewed
Jul 26, 2023
| @@ -761,6 +767,9 @@ construct_runtime!( | |||
| Uniques: pallet_uniques::{Pallet, Call, Storage, Event<T>} = 51, | |||
| Nfts: pallet_nfts::{Pallet, Call, Storage, Event<T>} = 52, | |||
| ForeignAssets: pallet_assets::<Instance2>::{Pallet, Call, Storage, Event<T>} = 53, | |||
|
|
|||
| // Storage aux. | |||
| PagedList: pallet_paged_list::{Pallet} = 80, | |||
There was a problem hiding this comment.
Following the idiom of bags-list, let's name this something better, such that if it is used for a second time, the names don't collide?
kianenigma
reviewed
Jul 26, 2023
| "pallet-timestamp/std", | ||
| "pallet-transaction-payment/std", | ||
| "pallet-glutton/std", |
kianenigma
approved these changes
Jul 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
parachain-systempallet to use the paged-list pallet instead of aStorageValue<Vev<_>>for storing the pending upward messages.TODO: