Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Nacho/improve xcm emulator v2 #2576

Merged
merged 62 commits into from
May 18, 2023

Conversation

NachoPal
Copy link
Contributor

No description provided.

NachoPal and others added 30 commits April 24, 2023 11:16
* xcm remote lock config

* rename

* update lockfile for {"polkadot", "substrate"}

---------

Co-authored-by: parity-processbot <>
* bump zombienet version

* fix para registration args
Co-authored-by: parity-processbot <>
* Import Clippy config from Polkadot

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Auto clippy fix

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* No tabs in comments

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Prefer matches

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Dont drop references

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Trivial

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Refactor

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* add clippy to ci

* Clippy reborrow

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update client/pov-recovery/src/lib.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* Update client/pov-recovery/src/lib.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* Partially revert 'Prefer matches'

Using matches! instead of match does give less compiler
checks as per review from @chevdor.

Partially reverts 8c06096

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update .cargo/config.toml

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

* Revert revert 💩

Should be fine to use matches! macro since it is an explicit whitelist,
not wildcard matching.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: parity-processbot <>
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.160 to 1.0.162.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.160...1.0.162)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: parity-processbot <>
@NachoPal NachoPal marked this pull request as draft May 15, 2023 09:19
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the idea that we just use our own examples as there's less code to compile and maintain.

@bkontur
Copy link
Contributor

bkontur commented May 15, 2023

@NachoPal
I am not sure about name of the directory:
parachains/integration-tests/xcm-emulator
maybe something like:
parachains/integration-tests/emulated
or other better name :)

parachains/integration-tests/e2e
parachains/integration-tests/emulated

@NachoPal NachoPal marked this pull request as ready for review May 18, 2023 09:28
@NachoPal NachoPal requested review from a team as code owners May 18, 2023 10:45
@NachoPal NachoPal merged commit 1c6e64f into ru/feature/xcm-emulator May 18, 2023
@NachoPal NachoPal deleted the nacho/improve-xcm-emulator-v2 branch May 18, 2023 10:49
NachoPal added a commit that referenced this pull request May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.