Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[ci] Update runners for benchmarks #2138

Merged
merged 10 commits into from
Jan 26, 2023
Merged

[ci] Update runners for benchmarks #2138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c602bf7
[ci] Update runners for benchmarks
alvicsam Jan 24, 2023
845fc2c
run benchmarks in this pr to get weights
alvicsam Jan 25, 2023
5c6f0f2
run benches only
alvicsam Jan 25, 2023
efc24d8
comment .post jobs
alvicsam Jan 25, 2023
ca184bc
add docker env to benches
alvicsam Jan 25, 2023
a0e5f40
add git diff to artifacts
alvicsam Jan 25, 2023
617cb4b
divide assets
alvicsam Jan 25, 2023
d19e777
update weights
alvicsam Jan 25, 2023
bb85ed0
return ci
alvicsam Jan 25, 2023
8deb8a7
fix refs for benchmarks
alvicsam Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions parachains/runtimes/assets/statemine/src/weights/cumulus_pallet_xcmp_queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
//! Autogenerated weights for `cumulus_pallet_xcmp_queue`
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
//! DATE: 2022-12-21, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! HOSTNAME: `bm4`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz`
//! DATE: 2023-01-25, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! HOSTNAME: `runner-b3zmxxc-project-238-concurrent-0`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("statemine-dev"), DB CACHE: 1024

// Executed Command:
Expand Down Expand Up @@ -48,15 +48,15 @@ pub struct WeightInfo<T>(PhantomData<T>);
impl<T: frame_system::Config> cumulus_pallet_xcmp_queue::WeightInfo for WeightInfo<T> {
// Storage: XcmpQueue QueueConfig (r:1 w:1)
fn set_config_with_u32() -> Weight {
// Minimum execution time: 6_844 nanoseconds.
Weight::from_ref_time(7_122_000)
// Minimum execution time: 6_767 nanoseconds.
Weight::from_ref_time(7_044_000)
.saturating_add(T::DbWeight::get().reads(1))
.saturating_add(T::DbWeight::get().writes(1))
}
// Storage: XcmpQueue QueueConfig (r:1 w:1)
fn set_config_with_weight() -> Weight {
// Minimum execution time: 6_960 nanoseconds.
Weight::from_ref_time(7_173_000)
// Minimum execution time: 6_746 nanoseconds.
Weight::from_ref_time(7_070_000)
.saturating_add(T::DbWeight::get().reads(1))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand Down
46 changes: 23 additions & 23 deletions parachains/runtimes/assets/statemine/src/weights/frame_system.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
//! Autogenerated weights for `frame_system`
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
//! DATE: 2022-12-21, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! HOSTNAME: `bm4`, CPU: `Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz`
//! DATE: 2023-01-25, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! HOSTNAME: `runner-b3zmxxc-project-238-concurrent-0`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("statemine-dev"), DB CACHE: 1024

// Executed Command:
Expand Down Expand Up @@ -48,51 +48,51 @@ pub struct WeightInfo<T>(PhantomData<T>);
impl<T: frame_system::Config> frame_system::WeightInfo for WeightInfo<T> {
/// The range of component `b` is `[0, 3932160]`.
fn remark(b: u32, ) -> Weight {
// Minimum execution time: 3_919 nanoseconds.
Weight::from_ref_time(3_976_000)
// Minimum execution time: 3_628 nanoseconds.
Weight::from_ref_time(4_024_750)
// Standard Error: 0
.saturating_add(Weight::from_ref_time(411).saturating_mul(b.into()))
.saturating_add(Weight::from_ref_time(474).saturating_mul(b.into()))
}
/// The range of component `b` is `[0, 3932160]`.
fn remark_with_event(b: u32, ) -> Weight {
// Minimum execution time: 13_679 nanoseconds.
Weight::from_ref_time(13_807_000)
// Standard Error: 0
.saturating_add(Weight::from_ref_time(1_770).saturating_mul(b.into()))
// Minimum execution time: 13_918 nanoseconds.
Weight::from_ref_time(152_866_312)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all runtimes remark_with_event increased a lot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 times more than before, and I do not see anything changing for this extrinsic and its benchmark

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, some results might be worse, because cpu on new runners differs. With this PR we also set a new baseline for benchmarks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea its weird. Meanwhile remark stays pretty much the same. We can merge it but I will do some manual testing on one of the VMs.

// Standard Error: 5
.saturating_add(Weight::from_ref_time(1_926).saturating_mul(b.into()))
}
// Storage: System Digest (r:1 w:1)
// Storage: unknown [0x3a686561707061676573] (r:0 w:1)
fn set_heap_pages() -> Weight {
// Minimum execution time: 8_917 nanoseconds.
Weight::from_ref_time(9_108_000)
// Minimum execution time: 8_571 nanoseconds.
Weight::from_ref_time(9_056_000)
.saturating_add(T::DbWeight::get().reads(1))
.saturating_add(T::DbWeight::get().writes(2))
}
// Storage: Skipped Metadata (r:0 w:0)
/// The range of component `i` is `[0, 1000]`.
fn set_storage(i: u32, ) -> Weight {
// Minimum execution time: 4_078 nanoseconds.
Weight::from_ref_time(4_134_000)
// Standard Error: 2_191
.saturating_add(Weight::from_ref_time(624_841).saturating_mul(i.into()))
// Minimum execution time: 3_762 nanoseconds.
Weight::from_ref_time(3_902_000)
// Standard Error: 2_353
.saturating_add(Weight::from_ref_time(688_828).saturating_mul(i.into()))
.saturating_add(T::DbWeight::get().writes((1_u64).saturating_mul(i.into())))
}
// Storage: Skipped Metadata (r:0 w:0)
/// The range of component `i` is `[0, 1000]`.
fn kill_storage(i: u32, ) -> Weight {
// Minimum execution time: 4_078 nanoseconds.
Weight::from_ref_time(4_149_000)
// Standard Error: 965
.saturating_add(Weight::from_ref_time(446_865).saturating_mul(i.into()))
// Minimum execution time: 3_812 nanoseconds.
Weight::from_ref_time(3_983_000)
// Standard Error: 1_028
.saturating_add(Weight::from_ref_time(520_360).saturating_mul(i.into()))
.saturating_add(T::DbWeight::get().writes((1_u64).saturating_mul(i.into())))
}
// Storage: Skipped Metadata (r:0 w:0)
/// The range of component `p` is `[0, 1000]`.
fn kill_prefix(p: u32, ) -> Weight {
// Minimum execution time: 5_538 nanoseconds.
Weight::from_ref_time(5_728_000)
// Standard Error: 1_272
.saturating_add(Weight::from_ref_time(972_809).saturating_mul(p.into()))
// Minimum execution time: 5_474 nanoseconds.
Weight::from_ref_time(5_708_000)
// Standard Error: 1_233
.saturating_add(Weight::from_ref_time(1_157_262).saturating_mul(p.into()))
.saturating_add(T::DbWeight::get().writes((1_u64).saturating_mul(p.into())))
}
}
Loading