Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BlockId removal: refactor: Finalizer #1779

Merged
merged 8 commits into from
Oct 20, 2022
Merged

BlockId removal: refactor: Finalizer #1779

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b90639
BlockId removal: refactor: Finalizer
michalkucharczyk Oct 18, 2022
639cc30
Merge remote-tracking branch 'origin/master' into mku-blockid-finalizer
Oct 20, 2022
63a92bf
update lockfile for {"polkadot", "substrate"}
Oct 20, 2022
db5aeaf
Merge remote-tracking branch 'origin/master' into mku-blockid-finalizer
michalkucharczyk Oct 20, 2022
992f388
Merge remote-tracking branch 'origin/master' into mku-blockid-finalizer
michalkucharczyk Oct 20, 2022
4ce9133
update Cargo.lock
michalkucharczyk Oct 20, 2022
4142543
Cargo.lock update again
michalkucharczyk Oct 20, 2022
2d8a5b5
Merge remote-tracking branch 'origin/master' into mku-blockid-finalizer
Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/consensus/common/src/parachain_consensus.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ where

// don't finalize the same block multiple times.
if parachain.usage_info().chain.finalized_hash != hash {
if let Err(e) = parachain.finalize_block(BlockId::hash(hash), None, true) {
if let Err(e) = parachain.finalize_block(&hash, None, true) {
match e {
ClientError::UnknownBlock(_) => tracing::debug!(
target: "cumulus-consensus",
Expand Down