Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Adding integration tests #1426

Merged
merged 13 commits into from
Jul 5, 2022
Merged

Adding integration tests #1426

merged 13 commits into from
Jul 5, 2022

Conversation

NachoPal
Copy link
Contributor

@NachoPal NachoPal commented Jul 5, 2022

Integration tests for parachains

@NachoPal NachoPal added A0-pleasereview B0-silent Changes should not be mentioned in any release notes T7-system_parachains This PR/Issue is related to System Parachains. labels Jul 5, 2022
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside the spacing issues

.gitignore Show resolved Hide resolved
parachains/integration-tests/statemine/xcm/2_ump.yml Outdated Show resolved Hide resolved
parachains/integration-tests/statemine/xcm/4_hrmp.yml Outdated Show resolved Hide resolved
parachains/integration-tests/statemine/xcm/1_dmp.yml Outdated Show resolved Hide resolved
parachains/integration-tests/statemint/xcm/1_dmp.yml Outdated Show resolved Hide resolved
parachains/integration-tests/statemint/xcm/2_ump.yml Outdated Show resolved Hide resolved
parachains/integration-tests/statemint/xcm/4_hrmp.yml Outdated Show resolved Hide resolved
@NachoPal NachoPal changed the title Nacho/add integration tests Adding integration tests Jul 5, 2022
NachoPal and others added 11 commits July 5, 2022 10:16
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
…s.yml

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
…s.yml

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@gilescope
Copy link
Contributor

Might be nice to mention in the readme how to run the tests.

@NachoPal
Copy link
Contributor Author

NachoPal commented Jul 5, 2022

Might be nice to mention in the readme how to run the tests.

Ok, I still have to create a script to run them easily. I'll add a mention in the README then.

@NachoPal NachoPal merged commit b80db21 into master Jul 5, 2022
@NachoPal NachoPal deleted the nacho/add-integration-tests branch July 5, 2022 10:24
@bkchr
Copy link
Member

bkchr commented Jul 6, 2022

Why isn't that done with zombienet? We don't want to have X different testing tools that no one maintains. If there is support missing for stuff in zombienet, then we need to add support. XCM aka sending transactions is a really "standard" feature that zombienet should support. So, please port these tests to normal zombienet tests. (I know that zombienet can just run normal polkadot-js scripts, if that isn't enough we need to make it easier to send xcm messages)

CC @pepoviola

@NachoPal
Copy link
Contributor Author

NachoPal commented Jul 6, 2022

The tool was created to fulfil Statemine/t testing needs when zombienet was still in its very early stages and was something we couldn't use at all. I needed something stable, so initially it was working making use of polkadot-launch. Since zombienet became stable, we integrated it to the tool and now it can also be used alongside to deploy the network. It can aslo work on its own, letting teams to use it against their own deployed testnets.

Regarding your comment about "no one maintains", I do the same way Javier mantains zombienet, and the rest of the Common Good Parachains team members can do it also + the community. I strongly believe in the virtues of the tool and how it eases writing tests quickly. The tool has its own npm package, so it can also be considered to be integrated directly in zombienet.

The tests have been in its own repository until now, and we have been using them already for months during each release, but now we need to add them here (it is just a bunch of yaml files) in our efforts to improve our release process. We need a CI job to run the tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes T7-system_parachains This PR/Issue is related to System Parachains.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants