-
Notifications
You must be signed in to change notification settings - Fork 379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside the spacing issues
parachains/integration-tests/statemine/xcm/3_hrmp-open-channels.yml
Outdated
Show resolved
Hide resolved
parachains/integration-tests/statemint/xcm/3_hrmp-open-channels.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
…s.yml Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
…s.yml Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Might be nice to mention in the readme how to run the tests. |
Ok, I still have to create a script to run them easily. I'll add a mention in the README then. |
Why isn't that done with zombienet? We don't want to have X different testing tools that no one maintains. If there is support missing for stuff in zombienet, then we need to add support. XCM aka sending transactions is a really "standard" feature that zombienet should support. So, please port these tests to normal zombienet tests. (I know that zombienet can just run normal polkadot-js scripts, if that isn't enough we need to make it easier to send xcm messages) CC @pepoviola |
The tool was created to fulfil Statemine/t testing needs when zombienet was still in its very early stages and was something we couldn't use at all. I needed something stable, so initially it was working making use of polkadot-launch. Since zombienet became stable, we integrated it to the tool and now it can also be used alongside to deploy the network. It can aslo work on its own, letting teams to use it against their own deployed testnets. Regarding your comment about "no one maintains", I do the same way Javier mantains zombienet, and the rest of the Common Good Parachains team members can do it also + the community. I strongly believe in the virtues of the tool and how it eases writing tests quickly. The tool has its own npm package, so it can also be considered to be integrated directly in zombienet. The tests have been in its own repository until now, and we have been using them already for months during each release, but now we need to add them here (it is just a bunch of yaml files) in our efforts to improve our release process. We need a CI job to run the tests. |
Integration tests for parachains