Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename canvas to contracts #1265

Merged
merged 17 commits into from
May 18, 2022
Merged

Rename canvas to contracts #1265

merged 17 commits into from
May 18, 2022

Conversation

cmichi
Copy link
Contributor

@cmichi cmichi commented May 17, 2022 •
edited
Loading

Readme preview here.

Once this PR has been merged I'll create follow-ups for DevOps, polkadot-js, Contracts UI, our tutorials, and our docs.

@cmichi cmichi requested review from ascjones and athei May 17, 2022 02:37
@cmichi cmichi requested review from a team and chevdor as code owners May 17, 2022 02:37
@cmichi cmichi added A0-pleasereview A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes labels May 17, 2022
athei
athei approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chevdor What needs to be done regarding the changelog? Are the changes done in this PR sufficient?

Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cmichi and others added 2 commits May 17, 2022 16:14
@cmichi @athei
Update README.md
f726bed 
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
@cmichi
Fix funny indentation
4a06d88
@chevdor
Copy link
Contributor

chevdor commented May 17, 2022

@chevdor What needs to be done regarding the changelog? Are the changes done in this PR sufficient?

currently testing

@cmichi cmichi requested a review from paritytech-ci May 17, 2022 18:31
@athei
Copy link
Member

athei commented May 18, 2022

@chevdor What needs to be done regarding the changelog? Are the changes done in this PR sufficient?

currently testing

It seems that there is still some renaming to do:

ENOENT: no such file or directory, stat 'contracts-rococo-runtime/contracts-rococo_runtime.compact.compressed.wasm'

@paritytech-ci paritytech-ci requested a review from a team May 18, 2022 07:28
@chevdor
Copy link
Contributor

chevdor commented May 18, 2022

@athei @cmichi that should be fixed now. Confirmation in ~50min with https://github.com/paritytech/cumulus/actions/runs/2343935487

For the explanation, rust likes changing some - into _. We used to patch the wasm path for canvas-kusama looking at the -kusama part of the runtime name. There was no match with ...-rococo.

I added a commit to this PR to fix that and make it more generic with a broader regexp.

@athei
Copy link
Member

athei commented May 18, 2022

In this error the "canvas" name still turned up. Is this also fixed by this?

@chevdor
Copy link
Contributor

chevdor commented May 18, 2022

image

@chevdor
Copy link
Contributor

chevdor commented May 18, 2022 •
edited
Loading

You may have a look at the draft release generated by this test run.

NOTE: I will delete this draft release once this PR is merged.

@chevdor chevdor mentioned this pull request May 18, 2022
Merged
@cmichi
Copy link
Contributor Author

cmichi commented May 18, 2022

From my pov we can merge. @athei Any objections?

@athei
Copy link
Member

athei commented May 18, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit d0e13bc into master May 18, 2022
@paritytech-processbot paritytech-processbot bot deleted the cmichi-rename-canvas-to-contracts branch May 18, 2022 09:56
@ghzlatarev ghzlatarev mentioned this pull request Jul 29, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ascjones ascjones ascjones approved these changes

@chevdor chevdor chevdor approved these changes

@athei athei athei approved these changes

@alvicsam alvicsam alvicsam approved these changes

@sergejparity sergejparity sergejparity approved these changes

@paritytech-ci paritytech-ci Awaiting requested review from paritytech-ci

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cmichi @chevdor @athei @ascjones @alvicsam @sergejparity