This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
rename polkadot-collator to polkadot-parachain #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not every node has to be a collator.
alvicsam
approved these changes
May 6, 2022
joepetrowski
approved these changes
May 6, 2022
|
Yes please hold off a bit on merging, I would like to check carefully and we need to update some other repos. |
bkchr
approved these changes
May 8, 2022
sergejparity
approved these changes
May 8, 2022
skunert
reviewed
May 9, 2022
chevdor
suggested changes
May 9, 2022
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
skunert
approved these changes
May 10, 2022
but allows for patch releases by having a 0 at the end. (`-patch1` patch naming schemes were discussed but they were judged to cause downstream packagers pain.)
chevdor
approved these changes
May 10, 2022
This was referenced May 10, 2022
hbulgarini
suggested changes
May 12, 2022
There was a problem hiding this comment.
When the node is started without --collator option the node still prints the Polkadot Collator log:
./polkadot-collator --tmp --port 40337 --ws-port 9948 -- --execution wasm --chain polkadot-local-raw.json --port 30337
2022-05-12 13:45:26 Polkadot collator
2022-05-12 13:45:26 ✌️ version 5.4.0-4bbedb30b
...
2022-05-12 13:45:26 Is collating: no
|
bot merge |
gilescope
added a commit
that referenced
this pull request
May 13, 2022
* rename polkadot-collator to polkadot-parachain Not every node has to be a collator. * Update README.md Co-authored-by: Chevdor <chevdor@users.noreply.github.com> * rename docker file * Update .github/workflows/extrinsic-ordering-check-from-bin.yml Co-authored-by: Chevdor <chevdor@users.noreply.github.com> * Versioning scheme that tracks polkadot relay chain but allows for patch releases by having a 0 at the end. (`-patch1` patch naming schemes were discussed but they were judged to cause downstream packagers pain.) * update name * update lock file Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Jun 29, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Jul 9, 2022
� Conflicts: � Cargo.lock
3 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not every node has to be a collator.
Fixes #979