Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Ensure relay chain parent is the relay chain head #103

Merged
merged 93 commits into from
May 27, 2020
Merged

Ensure relay chain parent is the relay chain head #103

merged 93 commits into from
May 27, 2020

Conversation

cecton
Copy link
Contributor

@cecton cecton commented May 19, 2020 •
edited
Loading

Related to #7

cecton and others added 30 commits May 6, 2020 12:55
@cecton
Initial commit
655dc45 
Forked at: 032595d
Parent branch: origin/master
@cecton
Added subcommand to run polkadot
9a47c09
@cecton
Add command validation-worker
32e81cf
@cecton
Add storage_append to runtime
df0f832
@cecton
WIP
892d057 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
41f50ee 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
214e50d 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
cd131ff 
Forked at: 032595d
Parent branch: origin/master
@cecton
clean exit if possible
3212554
@cecton
wip
0286a88
@cecton
WIP
d38edea 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
3d162e0 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
62b544e 
Forked at: 032595d
Parent branch: origin/master
@cecton
.editorconfig
17887fc
@cecton
register working
a0eb356
@cecton
WIP
9961be4 
Forked at: 032595d
Parent branch: origin/master
@cecton
clean-up
baa4357
@cecton
Rename ProcessCleanUp to ChildHelper
fc408e4
@cecton
More clean-up
22b64de
@cecton
Runs integration test separately
a978970
@cecton
Merge commit 3acb6d0 (no conflict)
ee3832a 
Parent branch: origin/master
Forked at: 032595d
@cecton
Merge commit c163d87 (conflicts)
1267f80 
Parent branch: origin/master
Forked at: 032595d
@cecton
Simplify toml
368a582
@cecton
Merge commit e810cf3 (conflicts)
de2b666 
Parent branch: origin/master
Forked at: 032595d
@cecton
Merge commit d6ab13c (no conflict)
a17dd34 
Parent branch: origin/master
Forked at: 032595d
@cecton
Initial commit
31768ce 
Forked at: d6ab13c
Parent branch: origin/master
@cecton
Update substrate & polkadot branch
68b0dcf
@cecton @coriolinus
Update test/parachain/tests/integration_test.rs
e2f3fdc 
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
@cecton
Split polkadot service creation from service building/running
0361e14
@cecton
Applied suggestions
cde8935
cecton added 17 commits May 20, 2020 13:45
@cecton
Change implementation
0b6b980
@cecton
Revert "WIP"
0be5da4 
This reverts commit 0e0a464.
@cecton
Revert "WIP"
87ab4bd 
This reverts commit 8179b9f.
@cecton
Revert "Switch branch"
35268cd 
This reverts commit 526a029.
@cecton
CLEANUP
27bccd0 
Forked at: 032595d
Parent branch: origin/master
@cecton
Revert "Revert "WIP""
53830f0 
This reverts commit 87ab4bd.
@cecton
WIP
d82cc2c 
Forked at: 032595d
Parent branch: origin/master
@cecton
Revert "Revert "Switch branch""
299f802 
This reverts commit 35268cd.
@cecton
CLEANUP
afa1c7b 
Forked at: 032595d
Parent branch: origin/master
@cecton
CLEANUP
ce6b721 
Forked at: 032595d
Parent branch: origin/master
@cecton
Attempt to make a test for the validator
568d53c
@cecton
WIP
38a96c3 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
b5397bc 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
f3e61ab 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
d86fe57 
Forked at: 032595d
Parent branch: origin/master
@cecton
CLEANUP
44eb276 
Forked at: 032595d
Parent branch: origin/master
@cecton
format
4c0510d
bkchr
bkchr approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not have reviewed all the tests for each detail ;)

network/src/lib.rs Outdated
Ok(None) => {
return Err(Box::new(ClientError::UnknownBlock(relay_chain_leaf.to_string())));
},
Ok(Some(_)) => return Ok(Validation::Failure),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a trace log would be nice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

network/src/tests.rs Outdated
}

#[test]
fn check_relay_parent_does_not_fail() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not fail but the implementation checks for failing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah makes no sense, will rename that

network/src/tests.rs Outdated
hash: PHash,
) -> std::result::Result<Option<NumberFor<PBlock>>, sp_blockchain::Error> {
Ok(match hash.as_fixed_bytes() {
&[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0] => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use if hash == H256::from_low_u64_be(1) etc here. That is much shorter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

cecton added 4 commits May 26, 2020 16:46
@cecton
WIP
787fbd1 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
b05b90e 
Forked at: 032595d
Parent branch: origin/master
@cecton
WIP
a4489e6 
Forked at: 032595d
Parent branch: origin/master
@cecton
fix missing authorities
870092a
@cecton cecton merged commit 8f02e23 into master May 27, 2020
@cecton cecton deleted the cecton-ensure-replay-parent-eq-relay-head branch May 27, 2020 12:43
weichweich added a commit to KILTprotocol/cumulus that referenced this pull request Jun 23, 2020
@weichweich
Squashed commit of the following:
2b34fe1 
commit 1eec2cad1f92dece71a8813de18f3adaa3a3307f
Author: Albrecht <14820950+weichweich@users.noreply.github.com>
Date:   Wed May 27 09:45:54 2020 +0200

    kilt runtime in cumulus

commit 05a83e8
Author: Bastian Köcher <bkchr@users.noreply.github.com>
Date:   Fri Jun 19 13:15:56 2020 +0200

    Take storage root from parent header (paritytech#123)

commit 62c22b8
Author: Bastian Köcher <bkchr@users.noreply.github.com>
Date:   Thu Jun 18 12:10:20 2020 +0200

    Implement basic upward & downward messages (paritytech#118)

    * Start by replacing branch names and set `DownwardMessage`

    * Add the upward-message crate

    * Add Kusama & Polkadot

    * More work on getting the upward messages working

    * Fix build

    * Begin to integrate it into the test Parachain

    * Update

    * Make everything compile again

    * Switch to westend and print parachain account on startup

    * Use MultiSignature etc

    * Fix validate block

    * Some downward messages work

    * Update git reference

    * More downward messages integration

    * Update test runtime for downward messages

    * Enable downward message handler and withdraw send tokens

    * Add some docs

    * Begin to implement simple XCMP

    * More work

    * Fixes and make parachain id configurable

    * Make parachain ID be part of the genesis

    * Finishing the XCMP message demo

    * Update and fixes tests

    * Update branch

commit b082e7f
Author: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Date:   Thu Jun 18 03:54:47 2020 -0400

    Allow custom polkadot chainspec. (paritytech#122)

commit 8b1fd65
Author: Cecile Tonglet <cecile@parity.io>
Date:   Mon Jun 15 12:40:15 2020 +0200

    Update polkadot & substrate (paritytech#112)

commit 41376ce
Author: Cecile Tonglet <cecile@parity.io>
Date:   Thu Jun 11 12:39:20 2020 +0200

    Prefix logs of parachain and relaychain differently + remove light client of relay chain (paritytech#109)

commit b3603d1
Author: Bastian Köcher <bkchr@users.noreply.github.com>
Date:   Fri Jun 5 16:57:02 2020 +0200

    Update to latest Substrate & Polkadot (paritytech#107)

    * Update to latest Substrate & Polkadot

    * Replace --unsafe-rpc-export with --unsafe-rpc-external

    * Add --rpc-methods=Unsafe

    Documented in substrate 24486f52929e9e518eeccbc6ad6da70e9e5bdf8a

    * typos

    * more typo

    * fixed rpc expose

    * Disable the integration test

    Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>

commit 4c6b959
Author: Cecile Tonglet <cecile@parity.io>
Date:   Wed Jun 3 17:51:49 2020 +0200

    Enable mdns polkadot (paritytech#106)

    Fixes paritytech#57

commit 1afdba7
Author: Cecile Tonglet <cecile@parity.io>
Date:   Wed Jun 3 14:15:52 2020 +0200

    Reject blocks without justification which don't have the best number (paritytech#105)

    * Initial commit

    Forked at: 8f02e23
    Parent branch: origin/master

    * Reject blocks without justification

    * Revert "Reject blocks without justification"

    This reverts commit ee60e12.

    * WIP

    Forked at: 8f02e23
    Parent branch: origin/master

    * WIP

    Forked at: 8f02e23
    Parent branch: origin/master

    * WIP

    Forked at: 8f02e23
    Parent branch: origin/master

    * CLEANUP

    Forked at: 8f02e23
    Parent branch: origin/master

    * WIP

    Forked at: 8f02e23
    Parent branch: origin/master

    * WIP

    Forked at: 8f02e23
    Parent branch: origin/master

    * CLEANUP

    Forked at: 8f02e23
    Parent branch: origin/master

    * WIP

    Forked at: 8f02e23
    Parent branch: origin/master

    * WIP

    Forked at: 8f02e23
    Parent branch: origin/master

    * Move HeadData to primitives

    * Update network/src/lib.rs

    Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

    * Update network/src/lib.rs

    Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

    * CLEANUP

    Forked at: 8f02e23
    Parent branch: origin/master

    * fix

    * CLEANUP

    Forked at: 8f02e23
    Parent branch: origin/master

    * messages

    * for the greater good

    * Update primitives/src/lib.rs

    Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

    * Update network/src/lib.rs

    Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

    * Update network/src/lib.rs

    Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

    * Update network/src/lib.rs

    Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

    Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

commit 8f02e23
Author: Cecile Tonglet <cecile@parity.io>
Date:   Wed May 27 14:43:45 2020 +0200

    Ensure relay chain parent is the relay chain head  (paritytech#103)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cecton @bkchr