This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 380
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
xcmp-queue: Fix handling of encoded blobs
With #701 we tried to fix some infinite loop related to encoded blobs, however that lead actually to not being able to process encoded blobs at all. The reason for this is that `decode_all` doesn't consume the given input. The point of this function is that it returns an error if the data couldn't be decoded or there is still data left. However, this means that the check `remaining_fragments.len() < last_remaining_fragments.len()` would always fail. We remove the while loop, because we decode the entire fragment anyway or it fails. Aka, we don't need to loop here. Next we remove the broken check and we directly reset the `remaining_fragments` (because `decode_all` doesn't consume anything).
- Loading branch information
Showing
2 changed files
with
25 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters