Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for compatible scale and scale-info versions #1370

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Remove check for compatible scale and scale-info versions #1370

merged 4 commits into from
Oct 18, 2023

Conversation

smiasojed
Copy link
Collaborator

Summary

Closes #1309

  • [n] y/n | Does it introduce breaking changes?
  • [y] y/n | Is it dependent on the specific version of ink or pallet-contracts?
    Remove check for compatible scale and scale-info versions

Description

Compatible with ink>=5.0.0-alpha

Checklist before requesting a review

  • [y] My code follows the style guidelines of this project
  • [y] I have added an entry to CHANGELOG.md
  • [n] I have commented my code, particularly in hard-to-understand areas
  • [n] I have added tests that prove my fix is effective or that my feature works
  • [y] Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed marked this pull request as ready for review October 18, 2023 09:40
@ascjones ascjones merged commit 1421c8e into master Oct 18, 2023
11 checks passed
@ascjones ascjones deleted the sm/scale-check branch October 18, 2023 10:05
@smiasojed smiasojed mentioned this pull request Nov 30, 2023
Merged
@smiasojed smiasojed mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove check for compatible scale and scale-info versions
2 participants
@smiasojed @ascjones