Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for compatible scale and scale-info versions #1309

Closed
2 tasks done
cmichi opened this issue Sep 1, 2023 · 0 comments · Fixed by #1370
Closed
2 tasks done

Remove check for compatible scale and scale-info versions #1309

cmichi opened this issue Sep 1, 2023 · 0 comments · Fixed by #1370
Assignees

Comments

@cmichi
Copy link
Collaborator

cmichi commented Sep 1, 2023

Follow-up issue for use-ink/ink#1890.

In the past we had introduced a check into cargo-contract. For every cargo contract build/check it asserts that the ink! contract contains a scale dependency version that is compatible with the scale-info dependency version.

The check can be found here.

With the changes in use-ink/ink#1890 this check is now obsolete and it can be removed.

As use-ink/ink#1890 will only be available in ink! 5.0 we have to ensure that once you removed the check only ink! contracts >= 5.0 can be compiled with cargo-contract.

ToDo

  • Remove the check.
  • Make sure that cargo-contract is only compatible with ink! >= 5.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants