This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
feat: transaction notifications #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capi-multisig ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
peetzweg
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
LGTM.
Although waiting for an extrinsic to be finalized is actually crucial for ux, otherwise ui data will be inconsistent and users expect their extrinsic was successful, which still could fail.
Should not block merging this, however we need a follow up ticket to wait for finalized extrinsics imho.
|
we should ideally show "finalized" or "reverted" once that happens, but we don't need to wait 6 more seconds to display the events. all dapps i know of display them on block inclusion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of the custom
Notificationcomponent we have, showing toast notifications for transaction status and block inclusion events.Changed from running
.finalized()on theRunestoinBlockEvents().Usually apps display events on block inclusion, because waiting for finalization adds an extra 6 seconds and the app and network are perceived as slow. Because most blocks get finalized, showing the notifications once the tx is included makes sense. We do want to notify when the status changes to finalized as well, but couldn't find a way to do that in capi. paritytech/capi#1090