Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

Sync with latest cumulus and contracts pallet #113

Merged

Conversation

cmichi
Copy link
Contributor

@cmichi cmichi commented Dec 8, 2021

RandonmessCollectiveFlip was removed from the parachain template, there is no alternative for a source of randomness currently though. In the future the relay chain will provide one, I'll create a follow-up issue so that we don't forget about it.

@athei
Copy link
Member

athei commented Dec 8, 2021

RandonmessCollectiveFlip was removed from the parachain template

How does the template even compile then. frame_system needs a source of randomness.

@cmichi
Copy link
Contributor Author

cmichi commented Dec 8, 2021

Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that I remembered that incorrectly. frame_system does not need Randomness. Only three pallets do and none of them is in the cumulus template.

So right now there is no way to get secure/unpredictable randomness for a parachain?

@HCastano
Copy link
Contributor

HCastano commented Dec 8, 2021

I want to take a look before this gets merged 😃

Will do that later today

@cmichi
Copy link
Contributor Author

cmichi commented Dec 8, 2021

So right now there is no way to get secure/unpredictable randomness for a parachain?

I talked to @bkchr and the relay chain will eventually provide randomness to the parachains, but that's not implemented yet. Right now we don't have an alternative.

Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions on some XCM configs. Also, have you tested this out using parachain-launch?

runtime/src/lib.rs Outdated Show resolved Hide resolved
EnsureXcm<IsMajorityOfBody<RocLocation, ExecutiveBody>>,
>;
// We allow root only to execute privileged collator selection operations.
pub type CollatorSelectionUpdateOrigin = EnsureRoot<AccountId>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here

Copy link
Contributor Author

@cmichi cmichi Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the configuration for canvas was the same as in the parachain-template and there this change was introduced (specifically here). EnsureOneOf has also been removed from Substrate and is no longer available.

Maybe @nukemandan or @riusricardo can clarify if applying this change for canvas is correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this change comes from @apopiak (see comment here). In our case, since we're planning to be a CGP I think we should leave it as it was before

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

runtime/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revert the CollatorSelectionUpdateOrigin and we're good to merge

@HCastano HCastano merged commit 3600f90 into master Dec 9, 2021
@HCastano HCastano deleted the cmichi-sync-with-cumulus-parachain-template-2021-12-07 branch December 9, 2021 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants