-
Notifications
You must be signed in to change notification settings - Fork 21
Sync with latest cumulus
and contracts
pallet
#113
Sync with latest cumulus
and contracts
pallet
#113
Conversation
How does the template even compile then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that I remembered that incorrectly. frame_system
does not need Randomness
. Only three pallets do and none of them is in the cumulus template.
So right now there is no way to get secure/unpredictable randomness for a parachain?
I want to take a look before this gets merged 😃 Will do that later today |
I talked to @bkchr and the relay chain will eventually provide randomness to the parachains, but that's not implemented yet. Right now we don't have an alternative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions on some XCM configs. Also, have you tested this out using parachain-launch
?
runtime/src/lib.rs
Outdated
EnsureXcm<IsMajorityOfBody<RocLocation, ExecutiveBody>>, | ||
>; | ||
// We allow root only to execute privileged collator selection operations. | ||
pub type CollatorSelectionUpdateOrigin = EnsureRoot<AccountId>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the configuration for canvas
was the same as in the parachain-template
and there this change was introduced (specifically here). EnsureOneOf
has also been removed from Substrate and is no longer available.
Maybe @nukemandan or @riusricardo can clarify if applying this change for canvas
is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to revert the CollatorSelectionUpdateOrigin
and we're good to merge
RandonmessCollectiveFlip
was removed from the parachain template, there is no alternative for a source of randomness currently though. In the future the relay chain will provide one, I'll create a follow-up issue so that we don't forget about it.