Added netstandard2.0 reference assemblies support #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made System.Reflection.Emit a public dependency due to the Label type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as we discussed, this adds support for using the netstandard2.0 target as a reference assembly.
The location of the reference assembly is in
/refinstead of the standard/libin the NuGet, so it won't ever be copied to the output path, avoiding any issues with the reference assembly being used as full fledged library in an unknown runtime implementation (.net core / .net framework)The interesting thing is, we can ignore any IDE errors that are not related to the Public API (e.g. missing
DefinePInvokeMethodandCreateTypemethods). Any implementation level compile errors do not matter.