Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) RawRabbit.DependencyInjection.Ninject extension #70

Closed
wants to merge 1 commit into from
Closed

Conversation

videege
Copy link
Contributor

@videege videege commented Mar 16, 2016

This pull request adds a new package for using RawRabbit with Ninject. I have based it on the Autofac package - all dependencies are registered as singletons and parameter injection works the same way. I also used the Autofac tests as a basis for Ninject tests, which are passing in this pull request.

Thanks for developing RawRabbit - I hope this PR is useful.

…package for using RawRabbit with the Ninject container
@pardahlman
Copy link
Owner

@videege thanks! I'll have a look at this later today. Release 1.8.13 has no date set, but it should be within this week.

@pardahlman pardahlman added this to the 1.8.13 milestone Mar 16, 2016
@videege
Copy link
Contributor Author

videege commented Mar 16, 2016

I looked it over again and I noticed I didn't clean up the project.json completely - there are still some textual mentions of Autofac instead of Ninject - sorry!

@pardahlman
Copy link
Owner

@videege I created issue #72 for the Ninject package and made a few clean-up commits (88dbc5e, b8163fb, e1b84ef). The package RawRabbit.DependencyInjection.Ninject is now available on NuGet and the code itself is part of release 1.8.3. Thanks for the help 💯 ! I took the liberty to re-word your commit so that it follows the commit guidelines. Your name has not appeared on the contribution list, I hope that it is a cache issue (I've seen that before), rather than I re-worded the commit.

Thanks again, and let me know if you want to help out some more!

@pardahlman pardahlman closed this Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants