-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify parcel query to not require all graphs on startup #9426
Merged
irismoini
merged 16 commits into
v2
from
imoini/P2X-1171-modify-parcel-query-to-not-require-all-graphs
Dec 13, 2023
Merged
Modify parcel query to not require all graphs on startup #9426
irismoini
merged 16 commits into
v2
from
imoini/P2X-1171-modify-parcel-query-to-not-require-all-graphs
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irismoini
force-pushed
the
imoini/P2X-1171-modify-parcel-query-to-not-require-all-graphs
branch
from
December 7, 2023 05:18
680cf27
to
b8f3790
Compare
irismoini
force-pushed
the
imoini/P2X-1171-modify-parcel-query-to-not-require-all-graphs
branch
from
December 7, 2023 05:23
b8f3790
to
94db58f
Compare
Co-authored-by: Tanmoy Bhowmik <tbhowmik2@atlassian.com>
gorakong
approved these changes
Dec 13, 2023
irismoini
deleted the
imoini/P2X-1171-modify-parcel-query-to-not-require-all-graphs
branch
December 13, 2023 21:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR modifies Parcel-query so that it no longer strictly requires all of Parcel's graphs or
bundleInfo
on startup.💻 Examples
For example you no longer need the bundle graph to do queries on the asset graph. If you run parcel-query with
.stats
and thebundleGraph
is undefined you will now get the following output:and Parcel-query will not exit. Previously the output would simply be
on startup and Parcel-query would exit.
🚨 Test instructions
Tested manually with different scenarios. i.e. setting assetGraph to undefined and running
.getBundles
✔️ PR Todo