Simplify MSB code for code split bundle creation section #9312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
AGawrys
commented
Oct 17, 2023
| @@ -826,7 +745,34 @@ function createIdealGraph( | |||
| } | |||
|
|
|||
| assetReference.get(childAsset).push([dependency, bundle]); | |||
| continue; | |||
| } else { | |||
| bundleId = null; | |||
There was a problem hiding this comment.
Without this we hit a nullthrows/ assertion error internally, I assume because of the scope change of bundleId.
thebriando
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR consolidates MSB code in a few ways.
bundleandbundleIdinitialization so that bundleId lookup for MSB can occur, and alter later lookups to only occur ifbundleId === nulllazyortypechangebundle creation, reducing overall linesThis will make it easier to remove MSB code from this section especially if we decide that MSBs should not overwrite explicit code split points.