Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple workspaces/clients in Parcel for VSCode #9278

Merged
merged 24 commits into from
Oct 23, 2023

Conversation

celinanperalta
Copy link
Contributor

↪️ Pull Request

This PR allows the Parcel for VSCode extension to report separate errors in different VSCode projects. Previously, errors in one workspace would be reported across all projects that had the extension installed.

Note that this does not include quickfix changes, which are on lsp-ux-explorations.

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

lettertwo and others added 8 commits September 19, 2023 15:57
Disable js/ts validation for the workspace
(packages that have .tsconfig should still work)
If the server isn't running, the reporter should do nothing.
* WIP: lsp sentinel watcher

* garbage

* f

* add initial sentinel check to watch

* remove event emitter from reporter

* update README, add reporter README

* support multiple LSP clients

- changed reporter project root to used process.cwd
- only add client when workspace root matches project root

* remove generated files

* remove other generated files

* move vscode-extension-TODO into extension dir

* clean up

* remove unused import

---------

Co-authored-by: Celina Peralta <cperalta@atlassian.com>
@parcel-benchmark
Copy link

parcel-benchmark commented Sep 27, 2023

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.43s -16.00ms
Cached 268.00ms -9.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 240.00ms -16.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 239.00ms -17.00ms 🚀
dist/legacy/index.ff03421b.js 1.48kb +0.00b 343.00ms -18.00ms 🚀
dist/legacy/index.e9bb1616.js 1.06kb +0.00b 343.00ms -18.00ms 🚀
dist/modern/index.4a29d309.js 921.00b +0.00b 342.00ms -20.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 3.84s -68.00ms
Cached 401.00ms -6.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 323.00ms +18.00ms ⚠️
dist/UserProfile.8945a243.js 1.38kb +0.00b 323.00ms +18.00ms ⚠️
dist/NotFound.8b44a81d.js 269.00b +0.00b 323.00ms +18.00ms ⚠️
dist/logo.8dd07848.png 244.00b +0.00b 247.00ms +32.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 339.00ms +23.00ms ⚠️
dist/UserProfile.8945a243.js 1.38kb +0.00b 339.00ms +23.00ms ⚠️
dist/NotFound.8b44a81d.js 269.00b +0.00b 339.00ms +24.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 31.32s -408.00ms
Cached 2.13s +13.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/media-viewer.e993d1a1.js 536.13kb +0.00b 7.40s -2.53s 🚀
dist/ConfigPanelFieldsLoader.182d39bc.js 303.43kb +0.00b 7.40s +396.00ms ⚠️
dist/card.d06de810.js 138.91kb +0.00b 7.40s +396.00ms ⚠️
dist/ElementBrowser.e8f01080.js 61.94kb +0.00b 7.40s +396.00ms ⚠️
dist/esm.271a6e34.js 59.30kb +0.00b 7.40s +395.00ms ⚠️
dist/component-lazy.51d1dec9.js 58.94kb +0.00b 4.65s -450.00ms 🚀
dist/ConfigPanelFieldsLoader.3384e28b.js 15.74kb +0.00b 7.40s +395.00ms ⚠️
dist/ui.8c117104.js 14.48kb +0.00b 7.40s +396.00ms ⚠️
dist/ConfigPanelFieldsLoader.aa7dd375.js 13.63kb +0.00b 7.40s +395.00ms ⚠️
dist/pdfRenderer.a0700f46.js 11.90kb +0.00b 7.39s -2.43s 🚀
dist/mobile-upload.3baad8e4.js 7.79kb +0.00b 7.40s +396.00ms ⚠️
dist/mobile-upload.7a892a37.js 7.79kb +0.00b 7.40s +395.00ms ⚠️
dist/ru.0cf3f40e.js 2.81kb +0.00b 7.40s +396.00ms ⚠️
dist/uk.282f23b1.js 2.76kb +0.00b 7.40s +395.00ms ⚠️
dist/codeViewerRenderer.51140ec8.js 2.61kb +0.00b 7.40s -2.63s 🚀
dist/th.137e1013.js 2.60kb +0.00b 7.40s +395.00ms ⚠️
dist/vi.b46097db.js 2.09kb +0.00b 7.40s +395.00ms ⚠️
dist/tr.c85d90a9.js 2.03kb +0.00b 7.40s +395.00ms ⚠️
dist/sv.1c06c95c.js 1.98kb +0.00b 7.40s +395.00ms ⚠️
dist/zh_TW.b7c55aa6.js 1.86kb +0.00b 7.40s +395.00ms ⚠️
dist/zh.b01fe721.js 1.84kb +0.00b 7.40s +395.00ms ⚠️
dist/workerHasher.540c9790.js 1.56kb +0.00b 7.40s +397.00ms ⚠️
dist/workerHasher.c840c607.js 1.56kb +0.00b 7.40s +395.00ms ⚠️
dist/sk.4be9c93f.js 656.00b +0.00b 7.40s +396.00ms ⚠️
dist/simpleHasher.c14e20b4.js 589.00b +0.00b 7.40s +397.00ms ⚠️
dist/simpleHasher.23db7a52.js 589.00b +0.00b 7.40s +395.00ms ⚠️
dist/ro.8d5b380a.js 482.00b +0.00b 5.29s -1.60s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 2.88s +32.00ms
Cached 306.00ms -9.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

packages/reporters/lsp-reporter/src/LspReporter.js Outdated Show resolved Hide resolved
packages/reporters/lsp-reporter/src/LspReporter.js Outdated Show resolved Hide resolved
packages/utils/parcel-lsp/src/LspServer.ts Outdated Show resolved Hide resolved
packages/utils/parcel-lsp/src/LspServer.ts Outdated Show resolved Hide resolved
packages/utils/parcel-lsp/src/LspServer.ts Outdated Show resolved Hide resolved
packages/reporters/lsp-reporter/src/LspReporter.js Outdated Show resolved Hide resolved
packages/utils/parcel-lsp/src/LspServer.ts Outdated Show resolved Hide resolved
packages/utils/parcel-lsp/src/LspServer.ts Outdated Show resolved Hide resolved
celinanperalta and others added 11 commits October 6, 2023 16:43
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
@celinanperalta celinanperalta merged commit e92ba6c into v2 Oct 23, 2023
16 checks passed
@mischnic mischnic deleted the multi-workspace-parcel-ext branch October 24, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants