Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Currently, when the
inlineEnvironment
config in the JS transformer is used with an array value, it does a glob match against every environment variable in the process. This leads to a large drop in performance as it is performed for every JS file in the build.micromatch
, which is used for our glob matching, actually supports many to many matching which is much more performant for this type of case. This PR exposes a new glob API (globMatch
) which is now used in the JS transformer.Just change took a local build completion time from
~140s
to~70s
.While this is good, I do wonder if there's a way to optimize this further as this work should only be done once per build? It is currently done once per file.
🚨 Test instructions
No new tests as functionality hasn't changed.
✔️ PR Todo