Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning to this in CommonJS #8737

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Assigning to this in CommonJS #8737

merged 2 commits into from
Jan 3, 2023

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Jan 1, 2023

#8710 (comment)

(For good measure, I've added more this.* statements in the tests, but that top-level detection was working fine already.)

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.99s -94.00ms
Cached 393.00ms -50.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 111.00ms -219.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 112.00ms -219.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 112.00ms -219.00ms 🚀
dist/legacy/index.2c76ad23.js 1.66kb +0.00b 557.00ms -53.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 558.00ms -52.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 557.00ms -52.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 132.00ms +15.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 133.00ms +13.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 133.00ms +14.00ms ⚠️
dist/legacy/index.2c76ad23.js 1.66kb +0.00b 591.00ms +30.00ms ⚠️
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 592.00ms +30.00ms ⚠️
dist/modern/index.6be20f01.js 1.13kb +0.00b 592.00ms +30.00ms ⚠️
dist/legacy/index.html 826.00b +0.00b 766.00ms +47.00ms ⚠️
dist/modern/index.html 749.00b +0.00b 766.00ms +49.00ms ⚠️
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 374.00ms +23.00ms ⚠️
dist/modern/index.31cedca9.css 94.00b +0.00b 374.00ms +23.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 12.46s +148.00ms
Cached 533.00ms +1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 2.21m -726.00ms
Cached 2.61s -78.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 8.87s -91.00ms
Cached 324.00ms -21.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 737fada into v2 Jan 3, 2023
@devongovett devongovett deleted the cjs-this-assignment branch January 3, 2023 17:20
marcins pushed a commit to marcins/parcel that referenced this pull request Jul 14, 2023
* upstream/v2: (33 commits)
  v2.8.3
  Changelog for v2.8.3
  Address bug by updating an asset reference and merge conditions (parcel-bundler#8762)
  Fix CSS order when merging type change bundles (parcel-bundler#8766)
  fixing failing build for contributors on Linux using Node 18 (parcel-bundler#8763)
  Extension: Importers View and separate LSP protocol package (parcel-bundler#8747)
  Bump swc to fix sourcemaps with Windows line endings (parcel-bundler#8756)
  Apply HMR updates in topological order (parcel-bundler#8752)
  Make extension packaging work (parcel-bundler#8730)
  Typed api.storeResult (parcel-bundler#8732)
  Refactor LSP to use vscode-jsonrpc (parcel-bundler#8728)
  Bump swc (parcel-bundler#8742)
  Recursively check reachability when removing asset graphs from bundles in deduplication (parcel-bundler#6004)
  Fix tsc sourcemaps metadata (parcel-bundler#8734)
  Assigning to `this` in CommonJS (parcel-bundler#8737)
  Don't retarget dependencies if a symbol is imported multiple times with different local names (parcel-bundler#8738)
  Add a note about using flow in CONTRIBUTING.md (parcel-bundler#8731)
  filter out title execArgv to workers (parcel-bundler#8719)
  Document more of the BundleGraph class (parcel-bundler#8711)
  Fixed the hmr connection with host 0.0.0.0 (parcel-bundler#7357)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants