Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use traverseAssets in packager #8592

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Use traverseAssets in packager #8592

merged 1 commit into from
Oct 31, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Oct 31, 2022

This is more idiomatic and slightly faster in some special cases as it prevents the creation of thousands of public Dependency wrapper objects.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.80s -18.00ms
Cached 441.00ms +28.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 278.00ms -25.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 279.00ms -25.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 279.00ms -25.00ms 🚀
dist/legacy/index.2c76ad23.js 1.66kb +0.00b 477.00ms -33.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 477.00ms -34.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 477.00ms -34.00ms 🚀
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 285.00ms -24.00ms 🚀
dist/modern/index.31cedca9.css 94.00b +0.00b 285.00ms -24.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 281.00ms -42.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 282.00ms -43.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 281.00ms -42.00ms 🚀
dist/legacy/index.2c76ad23.js 1.66kb +0.00b 480.00ms -51.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 480.00ms -52.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 480.00ms -52.00ms 🚀
dist/legacy/index.html 826.00b +0.00b 619.00ms -50.00ms 🚀
dist/modern/index.html 749.00b +0.00b 619.00ms -50.00ms 🚀
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 292.00ms -38.00ms 🚀
dist/modern/index.31cedca9.css 94.00b +0.00b 292.00ms -38.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 11.29s -96.00ms
Cached 545.00ms +16.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 2.05m +748.00ms
Cached 3.36s -143.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 8.13s -32.00ms
Cached 327.00ms -50.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 4c273c3 into v2 Oct 31, 2022
@mischnic mischnic deleted the packager-traverseAssets branch October 31, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants