-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure edge exists before removal in Graph.removeEdge
#8554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. React HackerNews 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
thebriando
approved these changes
Oct 24, 2022
AGawrys
approved these changes
Oct 24, 2022
After upgrading to 2.8.0, I am seeing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Prior to PR #7927,
removeEdge
validated that an edge existed before attempting to remove it. The assertions were removed as the recursive nature ofremoveEdge
could lead to edges being deleted twice.While ignoring double removals makes sense when orphaned nodes/edges are being cleaned up, it's not ideal when calling into
removeEdge
externally. It can lead to a confusing developer experience whereremoveEdge
is called incorrectly on edges that don't exist but the Graph just silently ignores the request.This PR splits
removeEdge
into separate private and public APIs._removeEdge
- only used internally to the Graph, ignores edge delete requests that don't existremoveEdge
- validates the edge exists and then calls_removeEdge
, throws if the edge doesn't existOne drawback of this approach is that calls to
removeEdge
validate that the edge exists twice.💻 Examples
✔️ PR Todo