Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for storing empty assets with LMDB #7995

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Add test for storing empty assets with LMDB #7995

merged 4 commits into from
Apr 29, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Apr 22, 2022

The actual issue will be resolved once napi-rs/napi-rs#1144 is released and we bump napi-rs.
Bump lmdb to fix this until then: kriszyp/lmdb-js#161

Use napi-rs 2 in compat mode to fix this once and for all: napi-rs/napi-rs#1144, napi-rs/napi-rs#1147
Bump lmdb for good measure: kriszyp/lmdb-js#161

@parcel-benchmark
Copy link

parcel-benchmark commented Apr 22, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 10.96s -202.00ms
Cached 519.00ms -11.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 7.75s +36.00ms
Cached 323.00ms -4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 50893a7 into v2 Apr 29, 2022
@mischnic mischnic deleted the lmdb-crash branch April 29, 2022 07:06
gorakong pushed a commit that referenced this pull request Nov 3, 2022
…2022-04-22

* upstream/v2:
  Add test for storing empty assets with LMDB (#7995)
  GitHub Actions: disable fail-fast for integration_tests (#8007)
  Drop Node 12 in tests and add Node 16 (#7935)
  Update Flow to 0.176.3 (#8006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants