Feature: replace environmental variable with in binary expression #7954
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
reviewed
Apr 14, 2022
mischnic
reviewed
Apr 14, 2022
mischnic
reviewed
Apr 14, 2022
Comment on lines
52
to
62
| if self.env.contains_key(&left.value) { | ||
| return Expr::Lit(Lit::Bool(Bool { | ||
| value: true, | ||
| span: DUMMY_SP, | ||
| })); | ||
| } else { | ||
| return Expr::Lit(Lit::Bool(Bool { | ||
| value: false, | ||
| span: DUMMY_SP, | ||
| })); | ||
| } |
There was a problem hiding this comment.
You can remove the if by doing
return Expr::Lit(Lit::Bool(Bool {
value: self.env.contains_key(&left.value),
span: DUMMY_SP,
}));There was a problem hiding this comment.
Certainly! Thanks! 👍 9b66c82
devongovett
requested changes
Apr 20, 2022
| if let Expr::Ident(ref ident) = &*member.obj { | ||
| if !self.decls.contains(&id!(ident)) && &ident.sym == "process" { | ||
| if let MemberProp::Ident(ref prop) = member.prop { | ||
| if &prop.sym == "env" { |
There was a problem hiding this comment.
Maybe we should use the match_member_expr utility to match process.env as below?
…h of binary in expression
devongovett
force-pushed
the
feature/replace-env-in-binary-expression
branch
from
2f1c460 to
d4ffae8
Compare
devongovett
approved these changes
Apr 21, 2022
|
I misunderstood that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes: #7904
I implemented the feature to replace
inbinary expression ,whose right branch isprocess.envand left branch is string literal value, with boolean literal value.💻 Examples
into
🚨 Test instructions
prepare the test case to cover this.
✔️ PR Todo