Wasm version of JS Transformer #6360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to and will mark 1 task as "Done" when merged:
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
Apparently it's a known bug. @evanw crafted a novel workaround for this: evanw/esbuild@9ea2076 |
|
Thanks! Related: nodejs/node#36616, swc-project/swc#1352 But thankfully, the primary usecase at the moment is the browser anyway. For now, we also don't fallback on wasm if there's no suitable prebuild native module. |
mischnic
commented
May 29, 2021
| #[serde(with = "serde_bytes")] | ||
| code: &'a [u8], | ||
| code: Vec<u8>, |
There was a problem hiding this comment.
Not sure whether this being a Vec has worse performance, and if yes, how to still use a slice
AFAICT, before Vec was a local variable, so it shouldn't really change anything
There was a problem hiding this comment.
@devongovett What did you see while profiling that motivated the change from string to &'a [u8]?
devongovett
reviewed
Jun 3, 2021
| @@ -3,7 +3,7 @@ import type {JSONObject, EnvMap} from '@parcel/types'; | |||
| import type {SchemaEntity} from '@parcel/utils'; | |||
| import SourceMap from '@parcel/source-map'; | |||
| import {Transformer} from '@parcel/plugin'; | |||
| import {transform} from './native'; | |||
| import {init, transform} from '../native'; | |||
There was a problem hiding this comment.
init only exists in the wasm version?
There was a problem hiding this comment.
Yes. It's a promise (not a function returning a promise), so we don't really need that stub export for the non-wasm version, it's simply await undefined then.
It's only needed in the web wasm version (Node wasm is synchronous and native of course as well).
devongovett
approved these changes
Jun 3, 2021
mischnic
commented
Jun 3, 2021
Comment on lines
+11
to
+34
| // https://github.com/cloudflare/serde-wasm-bindgen/issues/10 | ||
| dependencies: result.dependencies?.map(d => ({ | ||
| ...d, | ||
| attributes: | ||
| d.attributes != null | ||
| ? Object.fromEntries([...d.attributes]) | ||
| : undefined, | ||
| })), | ||
| hoist_result: | ||
| result.hoist_result != null | ||
| ? { | ||
| ...result.hoist_result, | ||
| imported_symbols: Object.fromEntries([ | ||
| ...result.hoist_result.imported_symbols, | ||
| ]), | ||
| exported_symbols: Object.fromEntries([ | ||
| ...result.hoist_result.exported_symbols, | ||
| ]), | ||
| dynamic_imports: Object.fromEntries([ | ||
| ...result.hoist_result.dynamic_imports, | ||
| ]), | ||
| } | ||
| : undefined, | ||
| }; |
There was a problem hiding this comment.
(We can remove this again once RReverser/serde-wasm-bindgen#12 is merged)
RReverser
reviewed
Jun 3, 2021
| result.hoist_result != null | ||
| ? { | ||
| ...result.hoist_result, | ||
| imported_symbols: Object.fromEntries([ |
There was a problem hiding this comment.
Just noticed this while looking at the link from other PR and wanted to note here too that you can use Object.fromEntries(result.hoist_result.imported_symbols) directly without converting to an intermediate array.
There was a problem hiding this comment.
You're right. But even better, I can remove this altogether now: #6413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wasm version works, but for some reason Node waits for 2 seconds after the build is finished before actually exiting. (The napi version is unchanged!)
Wasm size: 5.3mb
The Wasm version not used on any platform (yet).
Closes T-951
There are 16 failing integration tests when switching to wasm:
Option<>is serialized intoundefinedinstead ofnull