WIP: Add Markdown Plugin #3384
Closed
WIP: Add Markdown Plugin #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephMart
commented
Aug 14, 2019
| type: 'png', | ||
| assets: ['100x100.png'] | ||
| } | ||
| ]); | ||
|
|
||
| let files = await outputFS.readdir(path.join(__dirname, '/dist')); |
There was a problem hiding this comment.
This test fails at this line with
FSError: ENOENT: /..../parcel/packages/core/integration-tests/test/dist does not existWhere exactly is the output supposed to be? Is the the Markdown Plugin I converted not configured properly? Thoughts?
There was a problem hiding this comment.
You should use the distDir variable from @parcel/test-utils here instead.
kwelch
reviewed
Aug 14, 2019
| describe.skip('markdown', function() { | ||
| it('should support bundling Markdown', async function() { | ||
| describe('markdown', function() { | ||
| it.only('should support bundling Markdown', async function() { |
There was a problem hiding this comment.
One thing I have also found helpful is using the --grep feature in mocha to regex to the specific test I want to run.
|
This PR seems inactive for a while, I can create another PR with the changes requested?! |
|
I think the main blocker for a Markdown plugin is what the output format should be (html, raw, a react component), related to that: #3477 |
|
Closing in favor of the more complete #3936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR tries to add markdown plugin for transforms. Fixes #3357
💻 Examples
🚨 Test instructions
✔️ PR Todo