-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Markdown support — v2 #2882
Add Markdown support — v2 #2882
Conversation
cc @tomfinney — should solve your issue here: #2538 (comment) @mischnic @devongovett Hey! Maybe there's something inherently wrong with this PR and you would send me back to the workbench having spent just a minute? 😅 |
Parcel 1 is feature-locked because of the ongoing development of Parcel 2. So this is very unlikely to be merged. |
@mischnic Thanks for your reply!
|
@kirillrogovoy the front matter stuff looks dope. It seems weird that this would not get merged into 1.x.x as the initial version of markdown processing was merged in. One my projects is currently locked to a specific version of Parcel prior to that because the update broke how I parsed meta data from the markdown files. Seems weird to let that in but to not then tie up all the loose threads. |
@kirillrogovoy it could get merged into v2. Although it’s probably better to wait untill we’ve figured out html for v2 Sent with GitHawk |
I don't mind waiting for v2. Although I'm still concerned with what @tomfinney and I mentioned. We already have Markdown support in master, but it's very limited. It made sense to not merge the preceding PR (#2538) due to the feature lock, but it makes less sense to not get it finished since we did merge it. |
gonna close this due to Parcel 1 not receiving any new features |
↪️ Markdown support — v2
Implements what originally was asked in #2274.
New features:
marked.config.js
See integration tests for examples.
I'll be happy to write the docs for Markdown support once we settle on these changes.
✔️ PR Todo