Minor logger improvement and a bugfix #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
changed the title
DeMoorJasper
changed the title
devongovett
force-pushed
the
feature/logger-improvement
branch
from
ef8f06f to
2a8d045
Compare
|
Made a slight refactor to create separate |
devongovett
approved these changes
Jul 7, 2018
2zH
pushed a commit
to 2zH/parcel
that referenced
this pull request
Jul 11, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a spinner using
ora, this replaces the status code.As this is already battletested it should fix some issues we've been seeing with status.
This PR also changes error logging to log the message using console.log instead of status
This also fixes a bug in lineCounter, as it wasn't being ansiStripped, which caused incorrect lineCounts (mainly for error Stacks)
Closes #923 Closes #349 Closes #1293