Fixup unit test

parcel-bundler · Mar 1, 2023 · 4b47954 · 4b47954
1 parent 5ad82aa
commit 4b47954
Showing 1 changed file with 43 additions and 46 deletions.
diff --git a/packages/core/core/test/SymbolPropagation.test.js b/packages/core/core/test/SymbolPropagation.test.js
@@ -399,6 +399,7 @@ function changeAsset(
       n => n.type === 'asset' && n.value.filePath === asset,
     ),
   );
+  node.usedSymbolsUpDirty = true;
   node.usedSymbolsDownDirty = true;
   cb(nullthrows(node.value.symbols));
   return [[node.id, node.value]];
@@ -508,52 +509,48 @@ describe('SymbolPropagation', () => {
     ]);
   });
 
-  // it('basic tree - asset symbol change export and error', async () => {
-  //   // prettier-ignore
-  //   let graph = await testPropagation(
-  //     [
-  //       ['/index.js', [], true, []],
-  //       ['/lib.js', [['f', {local: 'f'}]], true, ['f']],
-  //     ],
-  //     [
-  //       ['/index.js', '/lib.js', [['f', {local: 'f', isWeak: false}]], [['f']]],
-  //     ],
-  //   );
-
-  //   let changedAssets = [
-  //     ...changeAsset(graph, 'lib.js', symbols => {
-  //       symbols.delete('f');
-  //       symbols.set('f2', {
-  //         local: 'f2',
-  //         loc: undefined,
-  //       });
-  //     }),
-  //   ];
-
-  //   console.log('----');
-
-  //   await dumpGraphToGraphViz(graph, '2');
-  //   let errors = propagateSymbols({
-  //     options: DEFAULT_OPTIONS,
-  //     assetGraph: graph,
-  //     changedAssetsPropagation: new Set(new Map(changedAssets).keys()),
-  //     assetGroupsWithRemovedParents: new Set(),
-  //   });
-  //   await dumpGraphToGraphViz(graph, '3');
-
-  //   assertPropagationErrors(graph, errors, [
-  //     [
-  //       'lib.js',
-  //       [
-  //         {
-  //           message: "lib.js does not export 'f2'",
-  //           origin: '@parcel/core',
-  //           codeFrames: undefined,
-  //         },
-  //       ],
-  //     ],
-  //   ]);
-  // });
+  it('basic tree - asset symbol change export and error', async () => {
+    // prettier-ignore
+    let graph = await testPropagation(
+      [
+        ['/index.js', [], true, []],
+        ['/lib.js', [['f', {local: 'f'}]], true, ['f']],
+      ],
+      [
+        ['/index.js', '/lib.js', [['f', {local: 'f', isWeak: false}]], [['f']]],
+      ],
+    );
+
+    let changedAssets = [
+      ...changeAsset(graph, 'lib.js', symbols => {
+        symbols.delete('f');
+        symbols.set('f2', {
+          local: 'f2',
+          loc: undefined,
+        });
+      }),
+    ];
+
+    let errors = propagateSymbols({
+      options: DEFAULT_OPTIONS,
+      assetGraph: graph,
+      changedAssetsPropagation: new Set(new Map(changedAssets).keys()),
+      assetGroupsWithRemovedParents: new Set(),
+    });
+
+    assertPropagationErrors(graph, errors, [
+      [
+        'lib.js',
+        [
+          {
+            message: "lib.js does not export 'f'",
+            origin: '@parcel/core',
+            codeFrames: undefined,
+          },
+        ],
+      ],
+    ]);
+  });
 
   it('basic tree - dependency symbol change reexport', async () => {
     // prettier-ignore