fix(css-modules): Do not transform the container name in CSS Modules #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hashing container names is intentional. I think webpack just never updated to support newer css features. Do the options added in #739 help here, or do we need to add a new one? |
|
I added an option instead 👍 |
|
I think this should already be covered by the |
devongovett
approved these changes
Nov 3, 2024
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Nov 15, 2024
…2607) ### What? Disable CSS Modules renaming for containers. ### Why? We should match the behavior of webpack mode. See: parcel-bundler/lightningcss#835 ### How? - Closes PACK-3315 - Closes #71233
wyattjoh
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 28, 2024
…2607) ### What? Disable CSS Modules renaming for containers. ### Why? We should match the behavior of webpack mode. See: parcel-bundler/lightningcss#835 ### How? - Closes PACK-3315 - Closes #71233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: vercel/next.js#71233
Webpack css-loader does not transpile
@container