Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to write coverage text to file #609

Merged
merged 10 commits into from
Apr 27, 2021

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Apr 23, 2021

Just like for PHPUnit, you may want to store the "coverage text" to a file.

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #609 (43a39e8) into master (069856b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #609   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       606       612    +6     
===========================================
  Files             24        24           
  Lines           1854      1859    +5     
===========================================
+ Hits            1854      1859    +5     
Impacted Files Coverage Δ Complexity Δ
src/Runners/PHPUnit/BaseRunner.php 100.00% <100.00%> (ø) 27.00 <0.00> (+1.00)
src/Runners/PHPUnit/Options.php 100.00% <100.00%> (ø) 148.00 <1.00> (+5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069856b...43a39e8. Read the comment docs.

@Slamdunk
Copy link
Member

Type make to run the build locally, if you have php installed, so you don't have to wait GA

@Nyholm
Copy link
Contributor Author

Nyholm commented Apr 23, 2021

There, finally. =)

I should have checked for Makefiles before I flooded the CI. Anyhow, I believe this PR is ready for review

@Slamdunk Slamdunk merged commit 268d5b2 into paratestphp:master Apr 27, 2021
@Nyholm
Copy link
Contributor Author

Nyholm commented Apr 27, 2021

Wohoo. Thank you for merging

@Nyholm Nyholm deleted the coverage-text branch April 27, 2021 09:25
@Slamdunk
Copy link
Member

Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants