Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output skipped details on verbose output #570

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

Slamdunk
Copy link
Member

@Slamdunk Slamdunk commented Dec 7, 2020

No description provided.

@Slamdunk Slamdunk added the bug label Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #570 (e4f8479) into master (56c529e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #570   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       566       585   +19     
===========================================
  Files             24        24           
  Lines           1758      1796   +38     
===========================================
+ Hits            1758      1796   +38     
Impacted Files Coverage Δ Complexity Δ
src/Logging/JUnit/Reader.php 100.00% <100.00%> (ø) 58.00 <5.00> (+5.00)
src/Logging/JUnit/TestCase.php 100.00% <100.00%> (ø) 11.00 <0.00> (+3.00)
src/Logging/LogInterpreter.php 100.00% <100.00%> (ø) 32.00 <2.00> (+2.00)
src/Runners/PHPUnit/Options.php 100.00% <100.00%> (ø) 122.00 <1.00> (+7.00)
src/Runners/PHPUnit/ResultPrinter.php 100.00% <100.00%> (ø) 72.00 <1.00> (+2.00)
src/Runners/PHPUnit/Runner.php 100.00% <100.00%> (ø) 20.00 <0.00> (ø)
src/Runners/PHPUnit/Worker/WrapperWorker.php 100.00% <100.00%> (ø) 16.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c529e...e4f8479. Read the comment docs.

@Slamdunk Slamdunk merged commit e813025 into paratestphp:master Dec 7, 2020
@Slamdunk Slamdunk deleted the verbose_skipped branch December 7, 2020 09:14
'If given, debug output is printed. Example: --verbose=1',
0
'v|vv',
InputOption::VALUE_NONE,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI : This introduces a breaking change for the end user:

   [Symfony\Component\Console\Exception\RuntimeException]  
  The "--verbose" option does not accept a value.         

No worries, I'll fix it in my scripts - but wanted to share this for people with similar issues.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. As this is a tool and not a library, and the flag bugged as it never showed the skipping tests like phpunit, I didn't bother much, I'm honest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants