Coverage support for WrapperRunner, see #115 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public function run() | ||
| { | ||
| $this->verifyConfiguration(); | ||
| $this->initCoverage(); | ||
| $this->load(); | ||
| $this->printer->start($this->options); |
There was a problem hiding this comment.
You can pull these four lines up to BaseRunner::run
|
No idea how to review that and I can only blame myself that this feature is untested. |
|
Well, you already reviewed it by suggesting to pull up the common run() functionality. |
julianseeger
added a commit
that referenced
this pull request
Oct 23, 2014
Coverage support for WrapperRunner, see #115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I factored out a base class for Runner and WrapperRunner in order to make WrapperRunner support code coverage. Please review and pull.