Update to version 2.25.0 of Mbed TLS #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the code to PSA Crypto 1.0.1. Mbed Crypto aligned a few more things to PSA Crypto 1.0.1 which led to various simplifications of the code. Fixed the specification-defined constants. Removed key handle support. Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
ionut-arm
approved these changes
Mar 5, 2021
Comment on lines
+78
to
+81
| psa_key_type_t shim_PSA_KEY_TYPE_ECC_KEY_PAIR(psa_ecc_family_t curve); | ||
| psa_key_type_t shim_PSA_KEY_TYPE_ECC_PUBLIC_KEY(psa_ecc_family_t curve); | ||
| psa_key_type_t shim_PSA_KEY_TYPE_DH_KEY_PAIR(psa_dh_family_t group); | ||
| psa_key_type_t shim_PSA_KEY_TYPE_DH_PUBLIC_KEY(psa_dh_family_t group); |
There was a problem hiding this comment.
I'm ok with the change, but just to make sure this is what you wanted: you didn't change the parameter name even though it's not in the type name anymore.
There was a problem hiding this comment.
ah, maybe family would have been more appropriate but anyway the parameter name is optional for C header prototypes 🤡
| @@ -138,9 +133,6 @@ pub fn decrypt( | |||
| &mut plaintext_size, | |||
| ) | |||
| }) | |||
| .to_result(); | |||
| let key_close_handle_res = key_id.close_handle(key_handle); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the code to PSA Crypto 1.0.1.
Mbed Crypto aligned a few more things to PSA Crypto 1.0.1 which led to
various simplifications of the code.
Fixed the specification-defined constants.
Removed key handle support.
Fix #76