Add method to retrieve hash from AsymSign #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
reviewed
Feb 11, 2021
psa-crypto/src/types/algorithm.rs
Outdated
| @@ -437,6 +437,19 @@ impl AsymmetricSignature { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| /// Retrieves the specific hash that the `AsymmetricSignature` algorithm is restricted to. | |||
| pub fn hash(self) -> SignHash { | |||
There was a problem hiding this comment.
I would personally prefer returning Option<SignHash> and return None for EcdsaAny and RsaPkcs1v15SignRaw so that all different cases are covered for this method. Maybe differentiating between those cases will be useful in the future?
This commit adds a method to `AsymmetricSignature` to retrieve the hash algorithm it is restricted to. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
force-pushed
the
asym-sign-hash
branch
from
8af9833 to
249b826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a method to
AsymmetricSignatureto retrieve the hashalgorithm it is restricted to.
Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com