Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the bindgen dependency if not needed #68

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Dec 8, 2020

When compiling without no features, just the abstractred types are in, without any dependency on the bindgen generated types. Removing the dependency of bindgen makes the compilation of this crate faster and easier in those cases.

Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
@hug-dev hug-dev requested a review from ionut-arm December 8, 2020 16:24
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hug-dev hug-dev merged commit 18dd4dd into parallaxsecond:master Dec 9, 2020
@hug-dev hug-dev deleted the no-bindgen branch December 9, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants