Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocklist max_align_t in bindgen #42

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Blocklist max_align_t in bindgen #42

merged 1 commit into from
Jul 17, 2020

Conversation

joechrisellis
Copy link
Contributor

We observe the following test failure for i686:

failures:
---- psa_crypto_binding::bindgen_test_layout_max_align_t stdout ----
thread 'psa_crypto_binding::bindgen_test_layout_max_align_t'
panicked at 'assertion failed: `(left == right)`
  left: `16`,
 right: `24`: Size of: max_align_t',
     .../build/psa-crypto-sys-59266dd2c6e5c562/out/shim_bindings.rs:3:22153

This type isn't needed, so we can just blocklist it from bindgen.

ionut-arm
ionut-arm approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! However it seems you didn't "sign" your commit - you can add a signature by just doing git commit -s --amend --no-edit and then force-pushing the branch up

Blocklist max_align_t in bindgen
f502c3c 
We observe the following test failure for i686:

    failures:
    ---- psa_crypto_binding::bindgen_test_layout_max_align_t stdout ----
    thread 'psa_crypto_binding::bindgen_test_layout_max_align_t'
    panicked at 'assertion failed: `(left == right)`
      left: `16`,
     right: `24`: Size of: max_align_t',
         .../build/psa-crypto-sys-59266dd2c6e5c562/out/shim_bindings.rs:3:22153

This type isn't needed, so we can just blocklist it from bindgen.

Signed-off-by: Joe Ellis <joe.ellis@arm.com>
@hug-dev hug-dev linked an issue Jul 17, 2020 that may be closed by this pull request
psa-crypto-sys test fail on i686 #41
Closed
@hug-dev hug-dev added the bug Something isn't working label Jul 17, 2020
@hug-dev hug-dev merged commit 24ef379 into parallaxsecond:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionut-arm ionut-arm ionut-arm approved these changes

@hug-dev hug-dev hug-dev approved these changes

Assignees

@joechrisellis joechrisellis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

psa-crypto-sys test fail on i686
3 participants
@joechrisellis @hug-dev @ionut-arm