Add various improvements #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
force-pushed
the
various-improvements
branch
from
a5c2e93 to
7e15762
Compare
ionut-arm
approved these changes
Jun 2, 2020
| @@ -15,7 +15,7 @@ repository = "https://github.com/parallaxsecond/rust-psa-crypto" | |||
| links = "mbedcrypto" | |||
|
|
|||
| [build-dependencies] | |||
| bindgen = "0.50.0" | |||
| bindgen = "0.54.0" | |||
| @@ -162,6 +162,39 @@ impl From<Status> for psa_crypto_sys::psa_status_t { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "with-mbed-crypto")] | |||
| impl From<Error> for psa_crypto_sys::psa_status_t { | |||
There was a problem hiding this comment.
If you have this then you don't need to have the whole match again above, in the From<Status> for psa_status_t, you can just do Status::Error(error) => error.into()
There was a problem hiding this comment.
Good point! Will push this modification.
There was a problem hiding this comment.
Thanks! This was actually one of the things that I needed for the ResponseStatus update :)
This commit: * fixes a bug in build.rs where the shim library was not compiled when dynamically linking * add the psa_get_key_id function to the shim * allow to access psa-crypto-sys from psa-crypto if compiling with Mbed Crypto * add a conversion from Error to psa_status_t to avoid going to Status Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
hug-dev
force-pushed
the
various-improvements
branch
from
7e15762 to
94bbb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
dynamically linking
Crypto
Signed-off-by: Hugues de Valon hugues.devalon@arm.com