Improve build of psa-crypto-sys crate #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves on the build mechanism for the sys crate. It moves all temporary build material into OUT_DIR, including the mbedtls config.h file and the build products of the library. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
hug-dev
approved these changes
May 26, 2020
Comment on lines
+46
to
+47
| .arg("--write") | ||
| .arg(&(out_dir.clone() + "/config.h")) |
| "making mbedtls returned an error status", | ||
| )); | ||
| } | ||
| let mbed_build_path = Config::new("vendor") |
There was a problem hiding this comment.
The cmake crate automatically builds in OUT_DIR?
There was a problem hiding this comment.
Yes, that's one of the main reasons why I went with the crate version :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves on the build mechanism for the sys crate. It moves
all temporary build material into OUT_DIR, including the mbedtls
config.h file and the build products of the library.
Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com