Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default-features on serde #113

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

ithinuel
Copy link
Contributor

@ithinuel ithinuel commented Aug 1, 2023

Serde enables by default its std features, we do not want that.

@ionut-arm
Copy link
Member

Seems we're having the same problem as we did with tss-esapi - compiler too old for the log crate. Do we want to bump MSRV?

@egrimley-arm
Copy link
Collaborator

You could remove the change to ci.sh and rebase this onto main now.

Serde enables by default its std features.

Signed-off-by: Wilfried Chauveau <wilfried.chauveau@ithinuel.me>
@ithinuel
Copy link
Contributor Author

Updated. Hopefully it'll pass CI 🤞

@egrimley-arm egrimley-arm requested a review from ionut-arm August 22, 2023 09:17
@ionut-arm ionut-arm merged commit c5992ce into parallaxsecond:main Aug 22, 2023
@ithinuel ithinuel deleted the patch-1 branch August 22, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants