-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spiffy issue #635
Fix spiffy issue #635
Conversation
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
9c36077
to
fd1d59a
Compare
@@ -33,15 +33,48 @@ dependencies = [ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all these changes, or can we make these updates separately and include what is necessary for this change?
From the CI, it seems that the new hashbrown
package isn't compatible with the old compiler 1.53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are automatically done after running cargo update. Yes, I and Ionut had a chat on this. Looks like we need to update that to 1.56. But for this to happen we need to make sure that latest version of OpenSUSE Leap uses 1.56 or above. I have already asked Guillaume Gardet. Waiting for his response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, depending on what exactly changed in those two dependencies that we bumped, it could end in tens/hundreds of other dependencies getting bumped/added/removed... Such is life in Cargo Land.
The indexmap crate 1.9.1 uses a version of hashbrown crate which is not compilable with rust 1.53.0. This rust version is required for supporting OpenSUSE Leap. Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the Fix 🥇
Bump psa_crypto and spiffy versions to resolve the security advisory reported from the cargo audit check.
Resolves #602
Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com