Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlite stability tests #634

Merged

Conversation

gowthamsk-arm
Copy link
Contributor

This MR will add stability tests for the sqlite key info managers. The generate keys script has been modified to generate the sqlite
database keys and then use them for testing.

Closes #519

Signed-off-by: Gowtham Suresh Kumar gowtham.sureshkumar@arm.com

@gowthamsk-arm gowthamsk-arm requested a review from a team as a code owner September 5, 2022 13:23
@gowthamsk-arm gowthamsk-arm force-pushed the add_sqlite_stability_tests branch 4 times, most recently from 8d99d54 to 56c0fc9 Compare September 6, 2022 09:51
@ionut-arm
Copy link
Member

Does this depend on #628 ? If it'd be useful to have that here, then we can go review and get that merged

@gowthamsk-arm
Copy link
Contributor Author

As this MR involves building a new docker image, makes sense to have that merged so the CI pipelines are more efficient.

@gowthamsk-arm gowthamsk-arm force-pushed the add_sqlite_stability_tests branch from 56c0fc9 to a768252 Compare September 6, 2022 11:19
Copy link
Contributor

@mohamedasaker-arm mohamedasaker-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Thanks for the hard work!

I get the feeling that the testing infrastructure is more complicated than the actual service :)

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Unlike on-disk KIM, the SQLite KIM does not support same key
names for different providers. So SQLite database is generated
with provider extension (ex: rsa-mbed).

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
@gowthamsk-arm gowthamsk-arm force-pushed the add_sqlite_stability_tests branch from 58e239d to d55761f Compare September 6, 2022 18:41
@gowthamsk-arm gowthamsk-arm merged commit 431eb91 into parallaxsecond:main Sep 6, 2022
@gowthamsk-arm gowthamsk-arm deleted the add_sqlite_stability_tests branch February 21, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants