Make key slot release implicit #59
Conversation
|
|
||
| /// Wrapper around raw `psa_key_handle_t` which allows for easier manipulation of | ||
| /// handles and the attributes associated with them. | ||
| pub struct Key<'a>(psa_key_handle_t, &'a Mutex<()>); |
There was a problem hiding this comment.
That's how it was named initially, but I renamed it because I thought an operation called get_key_attributes sounds a bit weird for a key handle.
| /// Release the key stored under this handle. | ||
| pub fn release_key(&mut self) { | ||
| unsafe { | ||
| let _guard = self.1.lock().expect("Grabbing key handle mutex failed"); |
There was a problem hiding this comment.
I am wondering if there are any implications/safety concerns of putting a safe statement inside an unsafe block? Maybe that could be outside of it and still work?
There was a problem hiding this comment.
I'll have a look through the Nomicon again, see what they think
There was a problem hiding this comment.
I was thinking that if one of those safe function that we put in an unsafe block suddendly become unsafe, then we will still execute them without any warning 😕
But I do not know if that can happen
src/providers/mbed_provider/utils.rs
Outdated
|
|
||
| impl Drop for Key<'_> { | ||
| fn drop(&mut self) { | ||
| if self.0 != 0 { |
There was a problem hiding this comment.
Will the psa_close_key fail if the handle is 0? Maybe that check could be put in the release_key function if so.
There was a problem hiding this comment.
Not sure it does - we don't check the return status for close_key anyway! But we could put a check in release_key too.
There was a problem hiding this comment.
I've updated - now the check is done in release_key which is called every time a Key is dropped
This commit adds functionality to ensure that when key handles are dropped in the Mbed Provider, the slot is released automatically. Thus, there is no need to explicitly close handles anymore. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Key slots are now ✨automagically✨ released when the
Keyobject is dropped.Resolves #57