Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive the fuzz testing framework #429

Merged
merged 1 commit into from
May 19, 2021

Conversation

ionut-arm
Copy link
Member

This commit updates the fuzz testing framework to adapt to recent
changes in the Parsec service code, allowing us to run the fuzzer within
the same container that we use for CI.

Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com

@ionut-arm ionut-arm added security Issues related to the security and privacy of the service testing Task related to testing labels May 18, 2021
@ionut-arm ionut-arm requested a review from hug-dev May 18, 2021 15:28
@ionut-arm ionut-arm self-assigned this May 18, 2021
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!
Could it be possible to add a very short fuzzing run (maybe only building?) to the per-PR CI so that we are sure that it still works overtime?

fuzz/Cargo.toml Outdated
@@ -20,7 +20,7 @@ lazy_static = "1.4.0"
arbitrary = { version = "0.4.0", features = ["derive"] }

[build-dependencies]
parsec-client = "0.4.0"
parsec-client = "0.12.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time flies 🐦

@ionut-arm
Copy link
Member Author

Could it be possible to add a very short fuzzing run (maybe only building?) to the per-PR CI so that we are sure that it still works overtime?

Sure, will try to figure out a way to test it!

@ionut-arm ionut-arm force-pushed the revive-fuzz branch 3 times, most recently from 8e307ea to 615eb4c Compare May 19, 2021 13:04
This commit updates the fuzz testing framework to adapt to recent
changes in the Parsec service code, allowing us to run the fuzzer within
the same container that we use for CI.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
@ionut-arm
Copy link
Member Author

Short test is now part of the CI

@hug-dev
Copy link
Member

hug-dev commented May 19, 2021

Perfect!

@hug-dev hug-dev merged commit 5c7f6b6 into parallaxsecond:main May 19, 2021
@ionut-arm ionut-arm mentioned this pull request May 24, 2021
4 tasks
@ionut-arm ionut-arm deleted the revive-fuzz branch July 22, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Issues related to the security and privacy of the service testing Task related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants