Improve mandatory Provide methods #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
added
the
code health
ionut-arm
force-pushed
the
list-keys
branch
2 times, most recently
from
a504f8a to
d4bc02f
Compare
hug-dev
approved these changes
Jan 21, 2021
| client.generate_rsa_sign_key(key2.clone()).unwrap(); | ||
| client.set_provider(ProviderID::Tpm); | ||
| client.generate_rsa_sign_key(key3.clone()).unwrap(); | ||
| let providers = client.list_providers().expect("Failed to list providers"); |
There was a problem hiding this comment.
That's awesome!
This snippet shows the power of Parsec actually
This commit changes the way some methods on the Provide trait are implemented. Given that in some cases the methods _must_ be implemented by the providers (such as `list_keys`), there should be no default implementation for them and the tests must verify that they operate correctly. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
hug-dev
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way some methods on the Provide trait are
implemented. Given that in some cases the methods must be implemented
by the providers (such as
list_keys), there should be no defaultimplementation for them and the tests must verify that they operate
correctly.
Fixes #312