Use the new abstraction on the PKCS11 interface #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
added
the
platforms
ionut-arm
approved these changes
Dec 11, 2020
Comment on lines
+34
to
+40
| Ok(psa_asymmetric_encrypt::Result { | ||
| ciphertext: session | ||
| .encrypt(&mech, key, &op.plaintext) | ||
| .map_err(to_response_status)? | ||
| .into(), | ||
| }) |
|
I will wait for the Christmas period before merging this, waiting to see any comment on the |
|
The |
hug-dev
force-pushed
the
use-pkcs11
branch
4 times, most recently
from
db93861 to
bbd2358
Compare
Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
ionut-arm
approved these changes
Mar 22, 2021
Comment on lines
+189
to
+190
| let mut flags = Flags::new(); | ||
| let _ = flags.set_rw_session(true).set_serial_session(true); |
There was a problem hiding this comment.
A bit weird, but I guess it's ok (saying this because the setters for Flags are in the middle between normal setters and builder setters, so you can do this chaining, but the variable has to be mutable and you have to let _ the last return).
There was a problem hiding this comment.
Yes, might be worth a rework at some point!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use everything from the
newmodule inpkcs11.Close #272