Use thread pool instead of new thread per request #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
approved these changes
Oct 10, 2019
Yes, I'd think so, the admin can judge by themselves and maybe we should stick with |
|
I think using the number of CPUs is a good idea, there is this crate for that: https://github.com/seanmonstar/num_cpus |
|
|
This commit adds a thread pool to which all requests will be dispatched instead of creating a new thread for each request. Changes provided by: * Ionut Mihalcea (ionut.mihalcea@arm.com) * Hugues de Valon (hugues.devalon@arm.com) Change-Id: Ib8dc4fab3694d26a71f3f7b4c98b14dbc934d601 Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a threadpool to handle our requests instead of spinning up a new thread per request which would allow a DoS.
Resolves #29.