Add support for ListProviders operation update #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhowardarm
requested changes
Oct 3, 2019
src/providers/core_provider/mod.rs
Outdated
| @@ -42,8 +43,14 @@ impl Provide for CoreProvider { | |||
|
|
|||
| fn describe(&self) -> ProviderInfo { | |||
| ProviderInfo { | |||
| id: ProviderID::CoreProvider, | |||
| // Randomly generated UUID: 47049873-2a43-4845-9d72-831eab668784 | |||
There was a problem hiding this comment.
Can we replace the comment "Randomly generated UUID" with "Assigned UUID for this provider"? I want to convey the impression that these things are assigned once only at creation time, and then hold true forever. The comment as worded seems to give the impression that this could fluctuate.
src/providers/mbed_provider/mod.rs
Outdated
| @@ -234,8 +235,14 @@ impl Provide for MbedProvider { | |||
|
|
|||
| fn describe(&self) -> ProviderInfo { | |||
| ProviderInfo { | |||
| id: ProviderID::MbedProvider, | |||
| // Randomly generated UUID: 1c1139dc-ad7c-47dc-ad6b-db6fdb466552 | |||
There was a problem hiding this comment.
Also here, let's say "Assigned UUID for this provider" or something.
Assigns to each provider a random UUID. Change-Id: Iec4e387eeef831c2082cc6ef2988937d538f7221 Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
This commit adds functionality for the service to process requests that do not have an authentication field assigned. Changes provided by: * Ionut Mihalcea (ionut.mihalcea@arm.com) * Hugues de Valon (hugues.devalon@arm.com) Change-Id: I2fa57f1a466c811f3434b99753a1dcfa335f463c Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
|
Merging as Paul's comments have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigns to each provider a random UUID.
Change-Id: Iec4e387eeef831c2082cc6ef2988937d538f7221
Signed-off-by: Hugues de Valon hugues.devalon@arm.com