Improve TPM provider #168
Merged
Improve TPM provider #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes a couple of fixes in the TPM provider. * the TSS crate used has been updated to the latest one, including a few functionality updates; this now allows the session hash algorithm and the cipher used for sessions and primary key * more control over the format of the authentication value is now offered to admins; more precisely, they can provide string versions of hex values, prefixed by "hex:" Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
hug-dev
approved these changes
May 5, 2020
| # be empty, however we strongly suggest that you use a secure passcode. | ||
| # To align with TPM tooling, PARSEC allows "owner_hierarchy_auth" to have a prefix indicating a string value, | ||
| # e.g. "str:password", or to represent a string version of a hex value, e.g. "hex:1a2b3c". If no prefix is | ||
| # provided, the value is considered to be a string. | ||
| #owner_hierarchy_auth = "password" |
There was a problem hiding this comment.
Should we set str:password as default?
There was a problem hiding this comment.
We could, but as stated above it's not really needed
| @@ -16,4 +16,4 @@ manager_type = "OnDisk" | |||
| provider_type = "Tpm" | |||
| key_info_manager = "on-disk-manager" | |||
| tcti = "mssim" | |||
| owner_hierarchy_auth = "tpm_pass" | |||
| owner_hierarchy_auth = "hex:74706d5f70617373" # "tpm_pass" in hex | |||
There was a problem hiding this comment.
Is that different from "str:tpm_pass"?
There was a problem hiding this comment.
No, it isn't, just wanted to test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes a couple of fixes in the TPM provider.
functionality updates; this now allows the session hash algorithm and
the cipher used for sessions and primary key
offered to admins; more precisely, they can provide string versions of
hex values, prefixed by "hex:"
Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com
Fixes #120
Fixes #121